Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issue #9

Closed
wants to merge 3 commits into from
Closed

Fix lint issue #9

wants to merge 3 commits into from

Conversation

evshary
Copy link

@evshary evshary commented Aug 14, 2024

To deal with system test failure.

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
@evshary evshary requested a review from YuanYuYuan August 14, 2024 07:15
@evshary
Copy link
Author

evshary commented Aug 14, 2024

After some investigation, I found that the coding style between rolling and dev/1.0.0 is almost different. Especially in rmw_zenoh.cpp
ros2/rmw_zenoh@rolling...ZettaScaleLabs:rmw_zenoh:dev/1.0.0
It would be better to align the style first, then do the cpplint and uncrustify.

Close the PR now.

@evshary evshary closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant